Filter prefix in keys #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplemenmted in AmazonS3 storage adapter) but could also be done locally if there is no other way. The new parameter is optional and most storage adapter currently do not have implemented. They throw an Exception if you try to use it. Signed-off-by: Oliver Buschjost <github@oliver-buschjost.de>
Signed-off-by: Oliver Buschjost <github@oliver-buschjost.de>
Signed-off-by: Oliver Buschjost <github@oliver-buschjost.de>
|
I'm not convinced by the utility of this because Gaufrette is more a read/write system than anything else. |
|
My usecase of Gaufrette involves other external systems modifying content on the cloud storage. (This works as a watch-folder: they add content and when I can find it it is processed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to (optionally) prefix-filter for keys. I know that this once was already part of Gaufrette and was removed. However, as long as the proposed filter interface not available I would really like to have this included again.
The current method of retrieving all keys is just not suitable if you have to deal with a few 10K objects in an S3 or other cloud bucket.
My change is compatible with the current keys() method as it just adds an optional parameter. All adapters for which I did not implement the prefix filtering will throw an appropriate exception if you try to filter with a prefix.